Skip to content

Comments

feat(tokens): support optional metadata on client token creation#30

Merged
AdirAmsalem merged 1 commit intomainfrom
feat/client-token-metadata
Feb 22, 2026
Merged

feat(tokens): support optional metadata on client token creation#30
AdirAmsalem merged 1 commit intomainfrom
feat/client-token-metadata

Conversation

@AdirAmsalem
Copy link
Contributor

@AdirAmsalem AdirAmsalem commented Feb 22, 2026

Summary

  • Add keyword-only metadata parameter to tokens.create()
  • Always sends application/json, includes metadata key only when provided
  • Fully backward-compatible — no breaking changes

Tests

  • 2 new tests: metadata forwarding + empty-body behavior
  • All 99 tests pass

Usage

# Without metadata (backward-compatible)
token = await client.tokens.create()

# With metadata
token = await client.tokens.create(metadata={"role": "viewer"})

Add keyword-only metadata parameter to tokens.create(). Always
sends application/json, includes metadata key only when provided.

Includes 2 new tests verifying metadata forwarding and empty-body
behavior.
Copy link

@tomershlasky tomershlasky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a Pyhton expert but LGTM.

@AdirAmsalem AdirAmsalem merged commit 5874995 into main Feb 22, 2026
8 checks passed
@AdirAmsalem AdirAmsalem deleted the feat/client-token-metadata branch February 22, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants